fix: resetCamera and annotations for flipped viewports #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sedghi
commented
Nov 3, 2022
•
sedghi
commented
- resetViewport was broken after the new flip implementation
- tool rendering were broken since we were filtering based on the orientation which is not logical with the new flip via camera API
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sedghi
changed the title
swederik
approved these changes
Nov 4, 2022
NeilMacPhee
pushed a commit
to NeilMacPhee/cornerstone3D-beta
that referenced
this pull request
Nov 10, 2022
…#278) * fix: remove applyTx since flip is not on actor anymore * fix: make annotations appear on flipeed viewports * fix: reset camera for flipped viewports * fix build * fix test * fix: tests * fix build
NeilMacPhee
pushed a commit
to NeilMacPhee/cornerstone3D-beta
that referenced
this pull request
Nov 22, 2022
…#278) * fix: remove applyTx since flip is not on actor anymore * fix: make annotations appear on flipeed viewports * fix: reset camera for flipped viewports * fix build * fix test * fix: tests * fix build
wayfarer3130
pushed a commit
that referenced
this pull request
Jan 20, 2023
… of to zero (#278) This is needed when doing C-FIND with dcmjs-dimse, where "" needs to mean 'match everything', and not be converted to zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.